[ECP-9289] Adding Installment options in payment Links request #3232
[ECP-9289] Adding Installment options in payment Links request #3232khushboo-singhvi merged 1 commit intomainfrom
Conversation
khushboo-singhvi
temporarily deployed
to
internal
GitHub Actions
Inactive
Summary of ChangesHello @khushboo-singhvi, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request integrates Adyen's installment functionality into the PayByLink payment method. By adding a new data builder and updating the dependency injection configuration, the system can now dynamically generate and include installment options in payment requests, providing greater flexibility for customers to manage their payments. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
The pull request successfully introduces installment options for PayByLink payment requests. The new InstallmentOptionsDataBuilder class is well-structured and correctly processes configuration rules to determine eligible installment values based on the order amount and credit card brand. The accompanying unit tests are comprehensive, covering various scenarios and edge cases, which is excellent for ensuring code quality and reliability. The di.xml changes correctly integrate the new data builder into the Magento dependency injection system. Overall, the implementation is robust and follows good practices.
|
3 participants
Description
This PR aims at building the InstallmentOptions for the PayByLink paymentLinks request. Now the plugin supports Installments for the PayByLink Payment Method
Fixes
#2660